Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deletion of a non-existent account overwrites with 0s #448

Open
gballet opened this issue Aug 20, 2024 · 1 comment
Open

deletion of a non-existent account overwrites with 0s #448

gballet opened this issue Aug 20, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@gballet
Copy link
Member

gballet commented Aug 20, 2024

In geth, there is an upcoming branch in which an account can be deleted if it doesn't exist. An actual call to deletion is made, which means that the account is ovewritten with 0s. Now, it never happened before since a non-existent account would not be "deleted", it would just be ignored. But it seems that in this new branch, an actual deletion command is sent.

This raises the question, independent of this geth branch: if an account is deleted, that doesn't exist in the tree, should it be "created" and then overwritten with 0s, or just ignored ?

@gballet gballet added bug Something isn't working enhancement New feature or request labels Aug 20, 2024
@gballet
Copy link
Member Author

gballet commented Aug 21, 2024

Writing down here after a talk with @jsign : this stuff is only needed for:

  1. this PR by Gary, which honestly sounds like something that should be handled at the client level and probably can be in trie/verkle.go.
  2. replays, which is the more tricky thing. It should be considered whether pure deletion can be implemented during replays. Probably not, owing to the impossibility of deleting a contract storage in verkle, but a clever trick might simplify all that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant