Convert gas values to integers #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested your branch and the output is not correct. It returns a HEX with two leading {"id":65,"jsonrpc":"2.0","result":"0x0x09184e72a000"} |
|
@frozeman duplicate "0x" should be removed now, thanks for catching that! |
| @@ -45,17 +40,22 @@ type EthereumApi struct { | |||
| register map[string][]*NewTxArgs | |||
|
|
|||
| db ethutil.Database | |||
|
|
|||
| defaultGasPrice *big.Int | |||
There was a problem hiding this comment.
These should just be global variables
tgerring
added a commit
that referenced
this pull request
Feb 24, 2015
Convert gas values to integers
|
👍 |
AusIV
pushed a commit
to NoteGio/go-ethereum
that referenced
this pull request
Jul 12, 2021
…ease/1.10.1-resolved-protocol-versions Fix allowing of selecting protocol versions after merge of 1.10.x
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Jun 13, 2022
* merge geth v1.10.15 * fix: Removed FastSync from cli server * fix: TestHeadersRLPStorage * Added t.skip(ETH2 in bor) * fix: flow in create consensus engine * bumped version * Fix typo * increase block time * remove file * bumped version * merge gethv1.10.17 * bumped version * fix failing tests * Bump Go version to v1.18 (ethereum#368) * Bump Go version to v1.18.1 * Build using netgo tag This will create a static build using Go native networking stack. Checked and it works stable for all archs and distros. * Fix meta * Bump version * Meta as stable Co-authored-by: Shivam Sharma <[email protected]> Co-authored-by: Manav Darji <[email protected]> Co-authored-by: Sandeep Sreenath <[email protected]> Co-authored-by: Victor Castell <[email protected]>
tanishqjasoria
pushed a commit
to tanishqjasoria/go-ethereum
that referenced
this pull request
Oct 31, 2023
…#373) * feat(evm): limit ecPairing precompile to use up to 4 inputs * update test cases * reorder test functions
mralj
pushed a commit
to NethermindEth/rollup-geth
that referenced
this pull request
Oct 1, 2024
…ultiple CPUs are available. (ethereum#373)
s1na
pushed a commit
to s1na/go-ethereum
that referenced
this pull request
Dec 2, 2024
CICD Improvement Dynamic Masternodes and Dynamic V2 Vote threshold Hardhat: Upgradeable Proxy support for XDC Bug Fix on API Supports the latest hardhat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370