Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/utils, internal/debug: fixes for debugging #2327

Merged
merged 2 commits into from
Mar 15, 2016
Merged

cmd/utils, internal/debug: fixes for debugging #2327

merged 2 commits into from
Mar 15, 2016

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Mar 11, 2016

No description provided.

@fjl
internal/debug: don't disable heap profile collection by default
cafdd59 
Setting runtime.MemProfileRate to 0 through the flag default
value makes it impossible to get an 'in-use' profile.
@robotally
Copy link

Vote Count Reviewers
👍 1 @karalabe
👎 0

Updated: Mon Mar 14 15:14:05 UTC 2016

@fjl fjl added this to the 1.4.0 milestone Mar 11, 2016
@fjl
cmd/utils, internal/debug: show all stacks for 10x Ctrl-C induced panic
c1343c8 
Go 1.6 only prints stacks for the current goroutine by default,
but for this panic we want to see all of them.
@fjl fjl changed the title internal/debug, cmd/utils: fixes for debugging cmd/utils, internal/debug: fixes for debugging Mar 12, 2016
@fjl fjl added review and removed in progress labels Mar 12, 2016
@karalabe
Copy link
Member

Don't we want to to enable full panics for spurious ones too? I.e. if something actually goes wrong?

@fjl
Copy link
Contributor Author

fjl commented Mar 14, 2016

The change in Go 1.6 is actually useful. Usually panics are related only to the goroutine that causes them (e.g. nil pointer, out of bounds) and the additional output is not helping. Sometimes people don't submit the whole log because it's too big.

@karalabe
Copy link
Member

LGTM 👍

karalabe
karalabe reviewed Mar 14, 2016
View reviewed changes
internal/debug/flags.go
@@ -55,6 +55,7 @@ var (
memprofilerateFlag = cli.IntFlag{
Name: "memprofilerate",
Usage: "Turn on memory profiling with the given rate",
Value: runtime.MemProfileRate,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't automatically turn on profiling, right? Also shouldn't something similar be done for blockprofilerate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It basically restores the default value. Memory profiling is always "on" in most programs, but has low impact on performance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a different story for block profiling though, so its not on by default. But you can turn it on through the API, unlike MemProfileRate.

karalabe added a commit that referenced this pull request Mar 15, 2016
@karalabe
Merge pull request #2327 from fjl/debug-fixes
e189fb8 
cmd/utils, internal/debug: fixes for debugging
@karalabe karalabe merged commit e189fb8 into ethereum:develop Mar 15, 2016
@obscuren obscuren removed the review label Mar 15, 2016
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Apr 17, 2024
@buddh0
BlobTx: implement EIP-4844 on BSC (ethereum#2279)
38db9bf 
* ci: temp enable blobtx branch ci run;
* Switch ON blobpool & ensure Cancun hardfork can occur (ethereum#2223)
* feat: support blob storage & miscs; (ethereum#2229)
* chainconfig: use cancun fork for BSC;
* feat: fill WithdrawalsHash when BSC enable cancun fork;
* rawdb: support to CRUD blobs;
* freezer: support to freeze block blobs;
* blockchain: add blob cache & blob query helper;
* freezer: refactor addition table logic, add uts;
* blobexpiry: add more extra expiry time, and logs;
* parlia: implement IsDataAvailable function;
* blob: refactor blob transfer logic;
* blob: support config blob extra reserve;
* blockchian: support to import block with blob & blobGasFee; (ethereum#2260)
* blob: implement min&max gas price logic;
* blockchian: support import side chain;
* blobpool: reject the banned address;
* blockchain: add chasing head for DA check;
* params: update blob related config;
* blockchain: opt data available checking performance;
* params: modify blob related params;
* gasprice: support BEP-336 blob gas price calculate;
* blobTx: mining + brodcasting (ethereum#2253)
* blobtx mining pass (ethereum#2282)
* Sidecar fetching changes for 4844 (ethereum#2283)
* ci: temp enable blobtx branch ci run;
* Switch ON blobpool & ensure Cancun hardfork can occur (ethereum#2223)
* feat: support blob storage & miscs; (ethereum#2229)
* chainconfig: use cancun fork for BSC;
feat: fill WithdrawalsHash when BSC enable cancun fork;
* rawdb: support to CRUD blobs;
* freezer: support to freeze block blobs;
* blockchain: add blob cache & blob query helper;
* freezer: refactor addition table logic, add uts;
* blobexpiry: add more extra expiry time, and logs;
* parlia: implement IsDataAvailable function;
* blob: refactor blob transfer logic;
* blob: support config blob extra reserve;
* blockchian: support to import block with blob & blobGasFee; (ethereum#2260)
* blob: implement min&max gas price logic;
* blockchian: support import side chain;
* blobpool: reject the banned address;
* blockchain: add chasing head for DA check;
* params: update blob related config;
* blockchain: opt data available checking performance;
* params: modify blob related params;
* gasprice: support BEP-336 blob gas price calculate;
* fix failed check for WithdrawalsHash (ethereum#2276)
* eth: include sidecars in fitering of body
* core: refactor sidecars name
* eth: sidecars type refactor
* core: remove extra from bad merge
* eth: fix handlenewblock test after merge
* Implement eth_getBlobSidecars && eth_getBlobSidecarByTxHash (ethereum#2286)
* execution: add blob gas fee reward to system;
* syncing: support blob syncing & DA checking;
* naming: rename blobs to sidecars;
* fix the semantics of WithXXX (ethereum#2293)
* config: reduce sidecar cache to 1024 and rename (ethereum#2297)
* fix: Withdrawals turn into empty from nil when BlockBody has Sidecars (ethereum#2301)
* internal/api_test: add test case for eth_getBlobSidecars && eth_getBlobSidecarByTxHash (ethereum#2300)
* consensus/misc: rollback CalcBlobFee (ethereum#2306)
* flags: add new flags to override blobs' params;
* freezer: fix blob ancient save error;
* blobsidecar: add new sidecar struct with metadata; (ethereum#2315)
* core/rawdb: optimize write block with sidecars (ethereum#2318)
* core: more check for validity of sidecars
* mev: add TxIndex for mev bid (ethereum#2325)
* remove useless Config() (ethereum#2326)
* fix WithSidecars (ethereum#2327)
* fix: fix mined block sidecar issue; (ethereum#2328)
* fix WithSidecars (ethereum#2329)

---------
Co-authored-by: GalaIO <[email protected]>
Co-authored-by: buddho <[email protected]>
Co-authored-by: Satyajit Das <[email protected]>
Co-authored-by: Eric <[email protected]>
Co-authored-by: zzzckck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fjl @robotally @karalabe @obscuren