Swarm/rpc v2 #2066
Closed
Swarm/rpc v2 #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whisper's expire and broadcast loops happen in two separate go routines. Whenever an envelope is being expired it's removed from the set of envelopes and it looses all information about the envelope, including the "known hash". After the envelope has been removed it can be re-accepted by a broadcasting peer putting back the envelope in the set of envelopes. Since the envelope broadcast loop is separate of the expire loop expired messages may be broadcast to other peer, resulting in messages **never** being dropped. This PR includes an expire check before adding new messages to the set of envelopes.
whisper: fixed broadcast race
cmd, crypto: updated web3
jrse: fix #1082, fail if setTimeout/setInterval lack callback
Makefile: add support for iOS cross compilation
Customizable protocol stacks
common: fix #2008, wrong hex prefix check
Makefile: enable iOS experimental builds (fix prev omission)
console: fix instance name printed incorrect on start
Created alternate versions of Trie and SecureTrie functions that can return a MissingNodeError (used by ODR services)
eth package creates new event mux
Also remove some duplication around address/index parsing.
cmd/utils: restore starting geth without any accounts and etherbase
Trie error handling
Makefile: build ARM v5/v6/v7, drop high API mobile clients
accounts: increase re-lock timeout to account for slow CI servers
|
❗ Pull request against
Updated: Mon Dec 14 06:18:10 UTC 2015 |
thanks to Felix Lange (fjl) for help with design & impl
|
against master by mistake |
sduchesneau
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Dec 19, 2023
draft release v1.3.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integrate #2035
fixes #2041