Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error pages support for swarm http API #3447

Closed
7 tasks
zelig opened this issue Dec 15, 2016 · 2 comments · Fixed by #14967
Closed
7 tasks

error pages support for swarm http API #3447

zelig opened this issue Dec 15, 2016 · 2 comments · Fixed by #14967
Milestone

Comments

@zelig
Copy link
Contributor

zelig commented Dec 15, 2016

current error messages are largely a relic from prePOC codebase.
We need to support error pages (possibly branded).

chunker join and connection errors should all be coded.
The http api matches the code with an http status code (may need non-standard)
and serves the corresponding error page in the manifest
falling back to an errors manifest specified via flag
or falling back to error pages in the code

The error pages should respect Accept headers

  • error types spec
  • error types -> status codes spec
  • error types represented within swarm manifest
  • formats types represented within swarm manifest
  • implement format/status/source driven error handling
  • implement error types in depo (should wait for network rewrite swarm network rewrite #2960)
  • proper documentation
@zelig
Copy link
Contributor Author

zelig commented Dec 16, 2016

@cobordism
Copy link
Contributor

cobordism commented Feb 3, 2017

we no longer have "seeker can't seek" and "unexpected end of JSON input" but we still need better errors for:

  • Manifest entry for '' not found
  • Manifest not found (is it a retrieval error or an ENS error?)
  • ERR_INCOMPLETE_CHUNKED_ENCODING -- what is this and why do we keep getting it?
  • ERR_CONTENT_LENGTH_MISMATCH -- why do we get this?

also look at #3401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants