Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum gas limit is hard-coded in error message #28083

Closed
ralexstokes opened this issue Sep 8, 2023 · 0 comments · Fixed by #28085
Closed

Minimum gas limit is hard-coded in error message #28083

ralexstokes opened this issue Sep 8, 2023 · 0 comments · Fixed by #28085

Comments

@ralexstokes
Copy link
Member

It seems like this code wants to be parametric over MinGasLimit but the value is hard-coded in the error message

go-ethereum/consensus/misc/gaslimit.go

Lines 38 to 40 in 5cf53f5

if headerGasLimit < params.MinGasLimit {
return errors.New("invalid gas limit below 5000")
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

consensus/misc: fix min gas limit error message 0xmuralik/go-ethereum
1 participant
@ralexstokes