Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile latest master 03585ed, fails with "undefined: atomic.Pointer" (golang1.19 required now?) #26679

Closed
J-A-M-E-5 opened this issue Feb 13, 2023 · 5 comments
Labels

Comments

@J-A-M-E-5
Copy link

J-A-M-E-5 commented Feb 13, 2023

Looks like Atomic Pointer are new feature in golang1.19, which means current Ubuntu unsupported out of the box. So need to fix README which currently states "Building geth requires both a Go (version 1.18 or later)".

System information

OS & Version: Linux
Commit hash : 03585ed

Expected behaviour

Compiles. Was working a few days ago. make clean doesn't fix.

Actual behaviour

$ make geth
env GO111MODULE=on go run build/ci.go install ./cmd/geth
>>> /usr/lib/go-1.18/bin/go build -ldflags "-X github.com/ethereum/go-ethereum/internal/version.gitCommit=03585ed7a932a6002569c382ab1d3b8d62819b07 -X github.com/ethereum/go-ethereum/internal/version.gitDate=20230213 -extldflags '-Wl,-z,stack-size=0x800000'" -tags urfave_cli_no_docs -trimpath -v -o /home/jm/src/geth/build/bin/geth ./cmd/geth
github.com/ethereum/go-ethereum/eth/filters
# github.com/ethereum/go-ethereum/eth/filters
eth/filters/filter_system.go:98:14: undefined: atomic.Pointer
util.go:48: exit status 2
exit status 1
make: *** [Makefile:12: geth] Error 1

$ go version
go version go1.18.1 linux/amd64

$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=22.04
DISTRIB_CODENAME=jammy
DISTRIB_DESCRIPTION="Ubuntu 22.04.1 LTS"

$ uname -a
Linux server3 5.15.0-60-generic #66-Ubuntu SMP Fri Jan 20 14:29:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
@J-A-M-E-5 J-A-M-E-5 changed the title Cannot compile latest master 03585ed, fails with "undefined: atomic.Pointer" Cannot compile latest master 03585ed, fails with "undefined: atomic.Pointer" (golang1.19 required now?) Feb 13, 2023
@Francesreid

This comment was marked as off-topic.

@Francesreid

This comment was marked as off-topic.

@Francesreid

This comment was marked as off-topic.

@s1na
Copy link
Contributor

s1na commented Feb 14, 2023

I mistakenly introduced a Go v1.19 feature into the codebase thinking it was already introduced before. Please either upgrade your golang to v1.19 or use this branch as a quickfix, which reverts the commit in question: #26686

@Francesreid

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants