Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracers: opcode filtering for JS tracers #24503

Closed
s1na opened this issue Mar 3, 2022 · 1 comment
Closed

tracers: opcode filtering for JS tracers #24503

s1na opened this issue Mar 3, 2022 · 1 comment
Assignees

Comments

@s1na
Copy link
Contributor

s1na commented Mar 3, 2022

Why should this feature exist?

There is a lot of overhead in calling from Go into JS via duktape. We can allow JS tracers to specify which opcodes they're interested in and have Geth only dispatch CaptureState events for those opcodes. Benchmarks are needed to see if the performance gain is worth it. Same needs to be done for the goja tracer (#23773) because there's no go-C context switch.

What are the use-cases?

E.g. the prestateTracer.

@holiman
Copy link
Contributor

holiman commented Dec 20, 2022

Any tracer where performance matters should be written as native one, IMO. I don't think we should pursue this

@s1na s1na closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@ligi @holiman @s1na and others