Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New location for legacy tests #24312

Closed
Zachinquarantine opened this issue Jan 30, 2022 · 1 comment · Fixed by #24451
Closed

New location for legacy tests #24312

Zachinquarantine opened this issue Jan 30, 2022 · 1 comment · Fixed by #24451

Comments

@Zachinquarantine
Copy link
Contributor

In the version of ethereum/tests currently used by Geth, the legacy tests are stored as a folder in the main test repo. In the newest version, they are in a seperate repo (ethereum/legacytests). This actually causes the CI to fail when using the new version, which blocks PRs such as #23570, which relies on the new version of the tests repo.
Version used by Geth:
slika

New version:
slika

I've found the line that is causing this problem, but I don't know how to update it so it's pointing to a submodule and not a folder.

@holiman
Copy link
Contributor

holiman commented Feb 3, 2022

Yes, this is something we must fix. Not urgent, but definitely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants