Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copydb panic because it can't retrieve the state tree in current height - 64 block #19266

Closed
huangyg11 opened this issue Mar 14, 2019 · 3 comments
Assignees
Milestone

Comments

@huangyg11
Copy link

The behavior of copydb ( or fast sync) is to sync state tree in the block of current height - 64, but it seems geth don't persist state tree in the block of current height - 64 before exist (it only persist current height, current height - 1, current height - 127) . So copydb will panic.

If I panic in copydb, I have to start geth and wait it syncing another 64 blocks and exist. Then invoke copydb again, it will work normally.

@fjl fjl added this to the Backlog milestone Jun 25, 2019
@fjl
Copy link
Contributor

fjl commented Jun 25, 2019

This needs a fix in eth/downloader because copydb uses it to "fast sync" into the local database.

@fjl fjl modified the milestones: Backlog, 1.9.1 Jun 25, 2019
@karalabe karalabe modified the milestones: 1.9.1, 1.9.2 Jul 23, 2019
@karalabe karalabe modified the milestones: 1.9.2, 1.9.3 Aug 13, 2019
@karalabe karalabe modified the milestones: 1.9.3, 1.9.4 Sep 4, 2019
@karalabe karalabe modified the milestones: 1.9.4, 1.9.5 Sep 19, 2019
@fjl fjl modified the milestones: 1.9.5, 1.9.6 Sep 20, 2019
@fjl fjl modified the milestones: 1.9.6, 1.9.7 Oct 3, 2019
@karalabe karalabe modified the milestones: 1.9.7, 1.9.8 Nov 8, 2019
@karalabe karalabe modified the milestones: 1.9.8, 1.9.9 Nov 27, 2019
@karalabe karalabe modified the milestones: 1.9.9, 1.9.10 Dec 6, 2019
@karalabe karalabe modified the milestones: 1.9.10, 1.9.11 Jan 21, 2020
@karalabe karalabe modified the milestones: 1.9.11, 1.9.12 Feb 18, 2020
@karalabe karalabe modified the milestones: 1.9.12, 1.9.13 Mar 16, 2020
@karalabe karalabe removed this from the 1.9.13 milestone Apr 20, 2020
@holiman
Copy link
Contributor

holiman commented May 14, 2020

I've trie to repro this, switching the pivot point back and forth. Everything seems to work, although I agree it should fail. However, I don't see why it would panic, so it would be good to see the stack trace of such a panic.

(yeah I know it's an old issue, sorry for not picking it up sooner)

@karalabe karalabe modified the milestones: 1.9.15, 1.9.16 Jun 8, 2020
@fjl fjl modified the milestones: 1.9.16, 1.9.17 Jul 10, 2020
@karalabe karalabe modified the milestones: 1.9.17, 1.9.18, 1.9.19 Jul 20, 2020
@karalabe karalabe modified the milestones: 1.9.19, 1.9.20 Aug 11, 2020
@karalabe karalabe modified the milestones: 1.9.20, 1.9.21 Aug 26, 2020
@karalabe
Copy link
Member

The command was dropped on master. We have (manual) state pruning shipped, which is better and faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants