Implement Pectra Devnet 4 changes for requests and 7702 #1016
Conversation
This PR incorporates the following updates to the Prague EIPs EIP-7002: add logging to system contract Update EIP-7002: add logging to system contract EIPs#8890 EIP-7251: max eb, change request to flat encoding Update EIP-7251: change request to flat encoding EIPs#8857 EIP-6110: deposits, change request to flat encoding Update EIP-6110: change request to flat encoding EIPs#8856 EIP-7002: withdrawals, change request to flat encoding Update EIP-7002: change request to flat encoding EIPs#8855 EIP-7685: change requests hash to flat hash Update EIP-7685: change requests hash to flat hash EIPs#8854
gurukamath
changed the title
|
Tracking PR for further updates |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## forks/prague #1016 +/- ##
===============================================
Coverage ? 75.82%
===============================================
Files ? 692
Lines ? 39264
Branches ? 0
===============================================
Hits ? 29771
Misses ? 9493
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gurukamath
changed the title
gurukamath
requested review from
petertdavies and
SamWilsn
and removed request for
petertdavies
src/ethereum/prague/fork.py
Outdated
| ) | ||
|
|
||
|
|
||
| def process_requests( |
There was a problem hiding this comment.
"requests" on its own is a little vague. Is there a more descriptive name we could use?
There was a problem hiding this comment.
Hmm. I think requests has come to be accepted as refering to the general purpose execution layer requests from EIP-7685. However, I see the point about it being confusing to non-EL audience. Switched it to process_general_purpose_requests
| @@ -8,20 +8,11 @@ | |||
| [EIP-7685]: https://eips.ethereum.org/EIPS/eip-7685 | |||
| """ | |||
|
|
|||
| from dataclasses import dataclass | |||
| from typing import Tuple, Union | |||
| from hashlib import sha256 | |||
There was a problem hiding this comment.
Should we create a wrapper in ethereum.crypto.hash like we do for keccak256?
There was a problem hiding this comment.
Unless we plan on moving this whole function (for computing the hash of a list of bytes) to ethereum.crypto, we will need it here
| evm_call_output[start : start + CONSOLIDATION_REQUEST_LENGTH] | ||
| ) | ||
| consolidation_requests += (encode_request(consolidation_request),) | ||
| m = sha256() |
There was a problem hiding this comment.
Weird. We should make a note somewhere (probably in ethereum.crypto.hash) of exactly what algorithm this is. I believe it's SHA2-256, right?
There was a problem hiding this comment.
Added a note to the function doc string
This PR incorporates the following updates to the Prague EIPs
EIP-7002: add logging to system contract Update EIP-7002: add logging to system contract EIPs#8890
EIP-7251: max eb, change request to flat encoding Update EIP-7251: change request to flat encoding EIPs#8857
EIP-6110: deposits, change request to flat encoding Update EIP-6110: change request to flat encoding EIPs#8856
EIP-7002: withdrawals, change request to flat encoding Update EIP-7002: change request to flat encoding EIPs#8855
EIP-7685: change requests hash to flat hash Update EIP-7685: change requests hash to flat hash EIPs#8854
Additionally, it implements the updates to EIP-7702
What was wrong?
The version of the EIP-7685 and related EIPs is not in line with the latest discussions
How was it fixed?
Update the EIPs