Use correct field names for validator requests #1015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request fields should be amed `pubkey` instead of `public_key` to be compatible with `execution-spec-tests` and latest EIP specs.
|
@etan-status As per latest updates under discussion for EIP-7685, I don't think the field name updates will be required since we just make the requests opaque. See EIP-7002 Update, EIP-7251 Update and EIP-6110 Update |
|
If all the discussions on these EIPs proceed as planned, this PR should be superseded by #1016 |
|
JSON-RPC still has the structure, no? |
|
But sure, that's more of a thing for the tests repo which already uses correct names for engine API (hive tests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request fields should be amed
pubkeyinstead ofpublic_keyto be compatible withexecution-spec-testsand latest EIP specs.