Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete comments about the purpose of created account tracking #979

Open
adhusson opened this issue Jul 25, 2024 · 0 comments
Open

Incomplete comments about the purpose of created account tracking #979

adhusson opened this issue Jul 25, 2024 · 0 comments
Labels
A-doc Area: documentation C-bug Category: this is a bug, deviation, or other problem. E-easy Experience: easy, good for newcomers

Comments

@adhusson
Copy link

Metadata

  • Hardfork: cancun

What was wrong?

In the description of the call to mark_account_created, the stated reason is gas refunds. But created accounts are also tracked to respect the constraints added to SELFDESTRUCT added by EIP-6780. This should be stated.

Similarly, the description of the definiition of mark_account_created only states that the tracking is needed for "an obscure edge case". EIP-6780 should be mentioned too.
@adhusson adhusson added A-doc Area: documentation C-bug Category: this is a bug, deviation, or other problem. labels Jul 25, 2024
@SamWilsn SamWilsn added the E-easy Experience: easy, good for newcomers label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-doc Area: documentation C-bug Category: this is a bug, deviation, or other problem. E-easy Experience: easy, good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adhusson @SamWilsn