Contract address made warm on aborted create call

[benSepanski]

Metadata

• Hardfork: london

What was wrong?

In the execution python specs, a contract_address is added to the accessed_addresses before the check validating that the sender nonce is small enough, the sender has enough balance, and the call-stack-depth has not overflowed.

This does not appear to match the behavior of CREATE as specified in Appendix H of the yellow paper. go-ethereum also appears to not include the new contract address if the aforementioned checks fail before loading the account at the address of the to-be-created account.

Sources

• https://ethereum.github.io/yellowpaper/paper.pdf Appendix H, p38

• execution-specs/src/ethereum/london/vm/instructions/system.py

  Lines 71 to 89 in 0f116b5

  	evm.accessed_addresses.add(contract_address)
  	create_message_gas = max_message_call_gas(Uint(evm.gas_left))
  	evm.gas_left -= create_message_gas
  	if evm.message.is_static:
  	raise WriteInStaticContext
  	evm.return_data = b""
  	sender_address = evm.message.current_target
  	sender = get_account(evm.env.state, sender_address)
  	if (
  	sender.balance < endowment
  	or sender.nonce == Uint(2**64 - 1)
  	or evm.message.depth + 1 > STACK_DEPTH_LIMIT
  	):
  	evm.gas_left += create_message_gas
  	push(evm.stack, U256(0))
  	return

• https://github.com/ethereum/go-ethereum/blob/65e5ca7d8126f7a8c708f8affb64f16c22cc63c0/core/vm/evm.go#L431-L466

Authors

@SleepingShell, @benSepanski