Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-4844 Spec Change: DATAHASH naming to BLOBHASH. #131

Closed

Conversation

spencer-tb
Copy link
Collaborator

Cosmetic change to match the spec update to EIP-4844: ethereum/EIPs#7001

Right now DATAHASH sort of conflicts with the EOF data section concept (which will want to have things like DATALOAD, DATACOPY, etc for). So I propose we change the mnemonic for blob hashes to BLOBHASH instead.

@spencer-tb
Copy link
Collaborator Author

Tagging the following task: #130

change op to BLOBHASH (cosmetic)

This PR will remain a draft until ethereum/EIPs#7001 is merged.

@spencer-tb spencer-tb marked this pull request as ready for review May 17, 2023 15:40
@spencer-tb spencer-tb requested a review from marioevz May 17, 2023 15:41
@spencer-tb
Copy link
Collaborator Author

Closing as will be deprecated by the following pytest port:
danceratopz#15

@spencer-tb spencer-tb closed this May 30, 2023
@spencer-tb spencer-tb deleted the spec-change-4844-blobhash-opcode branch July 7, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant