Engine API: Cancun specification #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralexstokes
reviewed
Jun 13, 2023
Co-authored-by: Alex Stokes <[email protected]>
8 tasks
ralexstokes
reviewed
Jun 21, 2023
src/engine/cancun.md
Outdated
| - `withdrawals`: `Array of WithdrawalV1` - Array of withdrawals, each object is an `OBJECT` containing the fields of a `WithdrawalV1` structure. | ||
| - `dataGasUsed`: `QUANTITY`, 64 bits | ||
| - `excessDataGas`: `QUANTITY`, 64 Bits | ||
| - `parentBeaconBlockRoot`: `DATA`, 32 Bytes |
There was a problem hiding this comment.
I'm having trouble checking out this PR locally, so I can follow up with the following changes:
updating toPayloadAttributesV3with theparent_beacon_block_root
There was a problem hiding this comment.
having to make changes in another PR #423
lightclient
approved these changes
Jun 21, 2023
ralexstokes
reviewed
Jun 21, 2023
ralexstokes
reviewed
Jun 21, 2023
src/engine/cancun.md
Outdated
| * method: `engine_newPayloadV3` | ||
| * params: | ||
| 1. [`ExecutionPayloadV3`](#ExecutionPayloadV3). | ||
| 2. `Array of DATA`, 32 Bytes - Array of blob versioned hashes to validate. |
There was a problem hiding this comment.
Suggested change
| 2. `Array of DATA`, 32 Bytes - Array of blob versioned hashes to validate. | |
| 2. `Array of DATA`, 32 Bytes - Array of blob versioned hashes to validate. | |
| 3. `parentBeaconBlockRoot`: DATA`, 32 Bytes - Parent beacon block root to validate according to EIP-4788. |
Co-authored-by: lightclient <[email protected]>
ralexstokes
reviewed
Jun 22, 2023
ralexstokes
reviewed
Jun 22, 2023
ralexstokes
reviewed
Jun 22, 2023
ralexstokes
reviewed
Jun 22, 2023
ralexstokes
reviewed
Jun 22, 2023
There was a problem hiding this comment.
generally looks good!
left some suggestions we should apply to most directly follow the latest CL spec: ethereum/consensus-specs#3421
where root is passed as a "sidecar" along with the ExecutionPayload rather than in the payload itself
This was referenced Jun 29, 2023
tersec
added a commit
to status-im/nim-web3
that referenced
this pull request
Jun 29, 2023
tersec
added a commit
to status-im/nim-web3
that referenced
this pull request
Jun 29, 2023
tersec
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jun 29, 2023
tersec
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jun 29, 2023
tersec
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jun 30, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces Cancun specification with the scope of changes defined in
blob-extension.md.TODO:
engine_exchangeTransitionConfigurationV1deprecation noticePayloadAttributesV3andengine_forkchoiceUpdatedV3to provide payload build process withparentBeaconBlockRoot