-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication for engine api #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good in general! left a few nits
spellcheck is complaining about all of the acronyms used here. Seems like we need to add them to the wordslist -- https://github.com/ethereum/execution-apis/blob/main/wordlist.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I left a few nits and question. Also, a general thing, IMO we should add an ## Authentication
section to the main specification and reference this document. This section may contain keypoints like CLI param, port, and a short description of the approach i.e. JWT reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Merging in next 24 hours
Follow-up to #162 .
Differences:
Todo: