Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseline: Split analysis and execution implementations #946

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Jul 4, 2024

Split Baseline analysis and execution implementations to separate files:
baseline.cpp → {baseline_analysis.cpp, baseline_execution.cpp}

Move the Baseline execution implementation to separate file:
baseline.cpp → baseline_execution.cpp
Move Baseline analysis implementation to separate file:
baseline.cpp → baseline_analysis.cpp.
Split Baseline analysis and execution implementations to separate files:
baseline.cpp → {baseline_analysis.cpp, baseline_execution.cpp}
@chfast chfast force-pushed the baseline/split_analysis_execution branch from 428f9f0 to a630196 Compare July 4, 2024 10:48
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (f3b5067) to head (a630196).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #946   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files         142      143    +1     
  Lines       16120    16120           
=======================================
  Hits        15200    15200           
  Misses        920      920           
Flag Coverage Δ
eof_execution_spec_tests 16.65% <100.00%> (ø)
ethereum_tests 26.99% <100.00%> (ø)
ethereum_tests_silkpre 18.70% <72.00%> (ø)
execution_spec_tests 17.98% <74.07%> (ø)
unittests 89.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/evmone/baseline.hpp 100.00% <ø> (ø)
lib/evmone/baseline_analysis.cpp 100.00% <100.00%> (ø)
lib/evmone/baseline_execution.cpp 100.00% <ø> (ø)

@chfast chfast merged commit a630196 into master Jul 4, 2024
26 checks passed
@chfast chfast deleted the baseline/split_analysis_execution branch July 4, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant