baseline: Improve code analysis API #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #941 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 146 147 +1
Lines 15487 15507 +20
=======================================
+ Hits 14541 14561 +20
Misses 946 946
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
reviewed
Jul 5, 2024
gumb0
approved these changes
Jul 5, 2024
|
Converted to draft, because I have better idea... |
chfast
force-pushed
the
baseline/code_api
branch
from
cb8bbd8
to
e380a81
Compare
chfast
force-pushed
the
baseline/code_api
branch
from
e4adf18
to
3016caf
Compare
chfast
changed the title
|
I changed the name for the "full unmodified code" to
|
|
gumb0
reviewed
Sep 12, 2024
lib/evmone/baseline_execution.cpp
Outdated
| @@ -335,19 +335,21 @@ evmc_result execute(evmc_vm* c_vm, const evmc_host_interface* host, evmc_host_co | |||
| { | |||
| auto vm = static_cast<VM*>(c_vm); | |||
| const bytes_view container{code, code_size}; | |||
| const auto eof_enabled = rev >= EVMC_PRAGUE; | |||
There was a problem hiding this comment.
Added as instr::REV_EOF1 but revision handling can be improved further. I wonder if we can make the revision opaque for EVMC.
chfast
commented
Sep 12, 2024
gumb0
approved these changes
Sep 12, 2024
For code analysis context only pass a `bool` value if EOF is enabled. This was the only information the analysis extracted from the previously used full EVM revision.
Expose more information from the `CodeAnalysis` class via new methods. Make fields private and hide some implementation details.
Take the EOF data section contents from the `CodeAnalysis` object instead of complicating the `ExecutionState`.
chfast
force-pushed
the
baseline/code_api
branch
from
3016caf
to
6e2f5d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the
evmc_revisionto the code analysis is too fine-grained for this public API. On Ethereum Mainnet EOF can be always enabled, but the options is left for other chain configurations.