Fix EOF initcode handling before EOF is enabled #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #893 +/- ##
=======================================
Coverage 98.50% 98.50%
=======================================
Files 130 130
Lines 15625 15655 +30
=======================================
+ Hits 15391 15421 +30
Misses 234 234
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pdobacz
reviewed
May 20, 2024
| tx.gas_limit = block.gas_limit; | ||
| pre.get(tx.sender).balance = tx.gas_limit * tx.max_gas_price + tx.value + 1; | ||
|
|
||
| const bytecode init_container = eof_bytecode(ret(0, 1)); |
There was a problem hiding this comment.
we usually use eof_bytecode(OP_INVALID) as the smallest valid eof container. Also, eof_bytecode(ret(0, 1)) fails validation due to wrong max stack height. However irrelevant to the logic being tested, I think it's safer to use a valid EOF code here.
Ah, I see the same is used above. I think this should be fixed there as well when we're at it.
The special rule of handling EOF initcode in CREATE/CREATE2 instructions should not be activated before EOF is activated.
chfast
force-pushed
the
eof/fix_eof_initcode
branch
from
e09d0f1
to
b449afc
Compare
pdobacz
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The special rule of handling EOF initcode in CREATE/CREATE2 instructions should not be activated before EOF is activated.