Use can_init for EOFCREATE validation

[pdobacz]

This was bugging me for a while.

We can leverage the same path in all cases where data section trunctaion is checked.

Not ideal, I tried a bunch of options, this seems least obtrusive. WDYT?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (af17b74) to head (2a7ddfd).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
- Coverage   98.50%   98.50%   -0.01%     
==========================================
  Files         130      130              
  Lines       15621    15619       -2     
==========================================
- Hits        15388    15386       -2     
  Misses        233      233              

Flag	Coverage Δ
ethereum-tests	27.95% <100.00%> (-0.01%)	⬇️
ethereum-tests-silkpre	19.70% <0.00%> (+<0.01%)	⬆️
execution-spec-tests	19.06% <0.00%> (+<0.01%)	⬆️
unittests	94.35% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
lib/evmone/eof.cpp	87.36% <100.00%> (-0.05%)	⬇️

[gumb0]

In #876 I'm considering moving this check out of validate_instructions() to a level above in validate_eof1() where related checks for EOFCREATE/container kind compatibility are done, then validate_instructions() won't have subcontainer_can_init argument at all.

But we can merge this first.

[pdobacz]

In #876 I'm considering moving this check out of validate_instructions() to a level above in validate_eof1() where related checks for EOFCREATE/container kind compatibility are done, then validate_instructions() won't have subcontainer_can_init argument at all.

But we can merge this first.

Ah yes, and there's also the refactors at #878. In case you have a feeling this will produce unnecessary conflicts, please let me know, I'll not merge until after dust settled

[gumb0]

I made another refactoring PR #888. If that one is merged, this one would be obsolete I think.
(This check is done in a different place and I used can_init() there right away)

[gumb0]

With #888 merged I think this can be closed