Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPT: Add support for "short" nodes #686

Merged
merged 4 commits into from
Aug 21, 2023
Merged

MPT: Add support for "short" nodes #686

merged 4 commits into from
Aug 21, 2023

Conversation

chfast
Copy link
Member

@chfast chfast commented Aug 15, 2023

For the branch and extended nodes in Merkle Patricia Trie, when the length of the encoded child is 31 or smaller the hashing of the child node is omitted.

@chfast chfast marked this pull request as ready for review August 15, 2023 19:45
@chfast chfast assigned gumb0 and rodiazet and unassigned gumb0 and rodiazet Aug 15, 2023
@chfast chfast requested review from gumb0 and rodiazet August 16, 2023 20:53
test/state/mpt.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #686 (5087032) into master (7cef356) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 5087032 differs from pull request most recent head 82c8f7a. Consider uploading reports for the commit 82c8f7a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
+ Coverage   97.52%   97.54%   +0.01%     
==========================================
  Files          86       86              
  Lines        8208     8215       +7     
==========================================
+ Hits         8005     8013       +8     
+ Misses        203      202       -1     
Flag Coverage Δ
blockchaintests 62.71% <ø> (ø)
statetests 74.10% <92.85%> (-0.03%) ⬇️
statetests-silkpre 23.24% <92.85%> (+<0.01%) ⬆️
unittests 95.12% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
test/unittests/state_mpt_test.cpp 100.00% <ø> (ø)
test/state/mpt.cpp 97.74% <100.00%> (+0.91%) ⬆️

@chfast chfast force-pushed the mpt_short_nodes branch 2 times, most recently from e4d8105 to 5087032 Compare August 20, 2023 14:26
For the branch and extended nodes in Merkle Patricia Trie,
when the length of the encoded child is 31 or smaller
the hashing of the child node is omitted.

This feature hadn't been needed to handle Ethereum State
until the withdrawals receipts were introduced.
@chfast chfast merged commit 4b2db8b into master Aug 21, 2023
3 checks passed
@chfast chfast deleted the mpt_short_nodes branch August 21, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants