-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable stack height validation for CALLF #594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodiazet
force-pushed
the
analyze-eof-refactor
branch
from
March 23, 2023 15:48
aaf0545
to
ffd9fa2
Compare
axic
reviewed
Mar 23, 2023
rodiazet
force-pushed
the
analyze-eof-refactor
branch
2 times, most recently
from
March 24, 2023 10:22
8814293
to
1036b0c
Compare
chfast
requested changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need two unit tests for each check.
rodiazet
force-pushed
the
analyze-eof-refactor
branch
3 times, most recently
from
March 24, 2023 17:26
f16a0c7
to
e86c78f
Compare
chfast
reviewed
Mar 27, 2023
rodiazet
force-pushed
the
analyze-eof-refactor
branch
from
March 27, 2023 08:39
e86c78f
to
d9e614a
Compare
rodiazet
force-pushed
the
analyze-eof-refactor
branch
from
March 27, 2023 13:51
d9e614a
to
b773e75
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #594 +/- ##
==========================================
+ Coverage 97.09% 97.11% +0.01%
==========================================
Files 74 74
Lines 7395 7443 +48
==========================================
+ Hits 7180 7228 +48
Misses 215 215
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
reviewed
Mar 27, 2023
rodiazet
force-pushed
the
analyze-eof-refactor
branch
from
March 28, 2023 09:02
b773e75
to
f7c0b29
Compare
chfast
reviewed
Mar 29, 2023
rodiazet
force-pushed
the
analyze-eof-refactor
branch
from
March 29, 2023 19:53
d23ad0a
to
386aedd
Compare
rodiazet
force-pushed
the
analyze-eof-refactor
branch
from
March 29, 2023 19:54
386aedd
to
2dac2d7
Compare
chfast
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling stack height validation requires passing EOF1Header to
callf
function context.