Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableOfContents #13210

Open
3 tasks
Tracked by #13043
corwintines opened this issue Jun 20, 2024 · 3 comments
Open
3 tasks
Tracked by #13043

TableOfContents #13210

corwintines opened this issue Jun 20, 2024 · 3 comments
Assignees
@pettinarip
Labels
dev required This requires developer resources Status: Stale This issue is stale because it has been open 30 days with no activity. testing

Comments

@corwintines
Copy link
Member

corwintines commented Jun 20, 2024 •
edited
Loading

Create story tests for TableOfContents component

Prerequisite

To get yourself up to speed on how we use storybook on ethereum.org, learn more here

What to do

  • Create story file /src/components/TableOfContents/TableOfContents.stories.tsx
  • Write story testing render of the TableOfContext component in context of use

Nice to have

  • Check if UpgradeTablesOfContents is redundant and if we can remove it
@corwintines corwintines mentioned this issue Jun 20, 2024
Open
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jun 20, 2024
@corwintines
Copy link
Member Author

corwintines commented Jun 20, 2024 •
edited
Loading

@pettinarip I think if we just test just the component from src/components/TableOfContents/index.tsx with a mobile view (believe we use story modes for this) then we should be good

Also, I added a nice to have possible refactor if it seems simple. I will look a bit more into this as well.

@corwintines corwintines added dev required This requires developer resources testing and removed needs triage 📥 This issue needs triaged before being worked on labels Jun 20, 2024
@pettinarip
Copy link
Member

@corwintines thanks. Ok! yes, I'll take a look at those cases. I'll probably add a separate story for the mobile view since it is not automatically displayed, you need to pass a isMobile prop.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pettinarip pettinarip

Labels
dev required This requires developer resources Status: Stale This issue is stale because it has been open 30 days with no activity. testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pettinarip @corwintines