Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create story for Logo component #13067

Closed
4 tasks
Tracked by #13043
corwintines opened this issue May 29, 2024 · 13 comments
Closed
4 tasks
Tracked by #13043

Create story for Logo component #13067

corwintines opened this issue May 29, 2024 · 13 comments
Assignees
Labels
feature ✨ This is enhancing something existing or creating something new Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@corwintines
Copy link
Member

corwintines commented May 29, 2024

Create story tests for Logo component

Prerequisite

To get yourself up to speed on how we use storybook on ethereum.org, learn more here

What to do

  • Move /src/components/Logo.tsx to /src/components/Logo/index.tsx
  • Fix any filepath changes to imports for the Logo component
  • Create story file /src/components/Logo/Logo.stories.tsx
  • Write story testing renter of the Logo component in context of use
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label May 29, 2024
@corwintines corwintines changed the title Logo Create story for Logo component May 29, 2024
@corwintines
Copy link
Member Author

corwintines commented May 29, 2024

Thanks for your interest in creating stories @TommWolf!

I'm going to assign you to this issue to start!

@corwintines
Copy link
Member Author

If you comment on this issue @TommWolf I can assign you :)

@TommWolf
Copy link

I am redy for this issue.

@wackerow
Copy link
Member

wackerow commented Jun 6, 2024

Thanks @TommWolf! Have assigned

@wackerow wackerow removed the needs triage 📥 This issue needs triaged before being worked on label Jun 6, 2024
@wackerow wackerow added this to the 13043 milestone Jun 6, 2024
@wackerow wackerow added the feature ✨ This is enhancing something existing or creating something new label Jun 6, 2024
@TommWolf
Copy link

TommWolf commented Jun 7, 2024

So this is application programming task? I am really willing to help. I am not programator. Do you think that even though it is possible for me?

@TommWolf
Copy link

TommWolf commented Jun 7, 2024

I have found the Logo.tsx component.

@corwintines
Copy link
Member Author

@TommWolf the plan here is to implement a story for testing. I have updated the description of this issue to have more information on what needs to be done here. Let me know if you have any questions.

@corwintines
Copy link
Member Author

@TommWolf any update?

I have unassigned for now, but let me know if you are still looking at this.

@corwintines
Copy link
Member Author

@tomasgrusz would you be interested in taking on this story?

@tomasgrusz
Copy link
Contributor

happy to pick this up @corwintines

@corwintines
Copy link
Member Author

Assigned @tomasgrusz!

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 28, 2024
@corwintines
Copy link
Member Author

CLosing this out with merged PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ✨ This is enhancing something existing or creating something new Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

No branches or pull requests

4 participants