make get_beacon_proposer_index safe for next epoch #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
requested review from
hwwhww and
JustinDrake
and removed request for
hwwhww
hwwhww
added a commit
to hwwhww/trinity
that referenced
this pull request
Feb 28, 2019
hwwhww
approved these changes
Feb 28, 2019
There was a problem hiding this comment.
LGTM!
And Python side sync during reviewing: ethereum/trinity#333
hwwhww
added a commit
to ethereum/trinity
that referenced
this pull request
Mar 4, 2019
…index` (#333) * Sync with ethereum/consensus-specs#694 * Fix mypy check * Update tests/eth2/beacon/test_beacon_validation.py Co-Authored-By: hwwhww <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and use in validator guide
get_committee_assignment