add syncnets to identity metadata for altair #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rolfyone
commented
Jun 2, 2021
rolfyone
commented
- Added as an optional field, it's only required once we hit altair and this will maintain compatibility with the current interface.
- Added as an optional field, it's only required once we hit altair and this will maintain compatibility with the current interface.
mpetrunic
reviewed
Jun 4, 2021
types/p2p.yaml
Outdated
| @@ -34,6 +34,12 @@ MetaData: | |||
| - description: "Bitvector representing the node's persistent attestation subnet subscriptions." | |||
| - $ref: "./primitive.yaml#/Hex" | |||
| - example: "0x0000000000000000" | |||
| syncnets: | |||
| allOf: | |||
| - description: "Bitvector representing the node's sync committee subnet subscriptions." | |||
There was a problem hiding this comment.
Should we add notice that it will be present after altair fork is activated?
There was a problem hiding this comment.
I wasn't sure of the wording, but did make an update. Happy to change it further if there's a better way of expressing it.
mpetrunic
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.