proof of concept altair blocks #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralexstokes
reviewed
Mar 18, 2021
mpetrunic
changed the title
mpetrunic
reviewed
Mar 19, 2021
mpetrunic
approved these changes
Mar 31, 2021
YEETBRT
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demonstrate the concept of a response object containing
version, and an object that is version dependent.Block could alternatively just have sync_aggregate as an optional field, but it's likely to be better to be consistent with the versioning approach.
There's a number of issues with this particular change, but I was hoping to get something as a demonstration rather than final version. Happy to update with any changes if it's close, but equally happy to discard if this has been done incorrectly.