Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated validator spec with rules for including execution requests in the beacon block body #3976

Merged
merged 14 commits into from
Oct 11, 2024

Conversation

lucassaldanha
Copy link
Contributor

@lucassaldanha lucassaldanha commented Oct 9, 2024

  • Defined/Updated ssz_serialize and ssz_deserialize functions
  • Updated GetPayloadResponse with execution_requests: Sequence[bytes]
  • Updated get_payload definition with extra detail re execution_requests
  • New section in "Constructing the BeaconBlockBody for ExecutionRequests"
  • Updated list[bytes] to Sequence[bytes]

@lucassaldanha
Copy link
Contributor Author

cc @mkalinin

specs/electra/validator.md Outdated Show resolved Hide resolved
specs/electra/validator.md Outdated Show resolved Hide resolved
@lucassaldanha lucassaldanha marked this pull request as ready for review October 10, 2024 04:27
specs/electra/validator.md Outdated Show resolved Hide resolved
specs/electra/validator.md Outdated Show resolved Hide resolved
@lucassaldanha
Copy link
Contributor Author

@hwwhww could you help me understand the test failures? 😢

@jtraglia
Copy link
Member

jtraglia commented Oct 10, 2024

@hwwhww could you help me understand the test failures? 😢

I think I know the reason. List is a remerkleable type and requires a max length component. For example:

List[DepositRequest, MAX_DEPOSIT_REQUESTS_PER_PAYLOAD]

And in this PR we use List without a length in the updated GetPayloadResponse type. Instead, we can use Sequence which does not require a max length component. I'll push a commit for this.

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems @jtraglia has solved the linter issue? (🙏)

tests/core/pyspec/eth2spec/utils/ssz/ssz_impl.py Outdated Show resolved Hide resolved
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you @lucassaldanha!

@jtraglia jtraglia merged commit a2e16c8 into ethereum:dev Oct 11, 2024
26 checks passed
@lucassaldanha lucassaldanha deleted the update-validator-electra branch October 11, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants