-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal blockhash override #2599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few suggestions and comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 !
Additionally we need to ensure this logic makes it into merge/validator.md
I'll do a final pass when that is added and you get the Hash32()
change in there.
closing in favor of adding a constant as in #2605 (comment) |
Adds a terminal block hash override for the merge fork as originally discussed here.
I'm creating this PR as a starting point for discussion while acknowledging that this might be somewhat controversial (more so than the total difficulty override) because coordinating on a specific blockhash might be perceived as more 'political'.