Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reasoning for explicitly creating Vector types? #905

Closed
ralexstokes opened this issue Apr 12, 2019 · 2 comments
Closed

Reasoning for explicitly creating Vector types? #905

ralexstokes opened this issue Apr 12, 2019 · 2 comments

Comments

@ralexstokes
Copy link
Member

If you refer to the BeaconState creation during get_genesis_beacon_state, you'll see some ssz vector types are constructed w/ an explicit Vector function (while others are not).

I expect this is the result of a bad merge and happy to clean it up if so. If the calls to Vector are supposed to be there, can we get some explanation? I can't find a reference elsewhere across the specs.

@JustinDrake
Copy link
Collaborator

I expect this is the result of a bad merge and happy to clean it up if so

Yes, we should be consistent. Having said that, SSZ initialisation will be massively cleaned up with default initial values (see here).

@ralexstokes
Copy link
Member Author

Gotcha, we can wait on #843 then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants