Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate adding EIP7594_MAX_BLOBS_PER_BLOCK and EIP7594_TARGET_BLOBS_PER_BLOCK #3952

Open
hwwhww opened this issue Oct 2, 2024 · 5 comments
Assignees
Labels
EIP-7594 PeerDAS

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Oct 2, 2024

Suggested by @barnabasbusa that we could add configurable parameters for devnet-4.

I'll put them with EIP7594_ prefix for now and switch them once we move to Fulu.

@hwwhww hwwhww self-assigned this Oct 2, 2024
@hwwhww hwwhww added the EIP-7594 PeerDAS label Oct 2, 2024
@barnabasbusa
Copy link
Member

barnabasbusa commented Oct 2, 2024

For historical reasons, we probably wanna redefine deneb as well:

# deneb renames? 
DENEB_BLOB_SIDECAR_SUBNET_COUNT = 6
DENEB_MAX_BLOBS_PER_BLOCK = 6
DENEB_TARGET_BLOBS_PER_BLOCK = 3

EIP7594_BLOB_SIDECAR_SUBNET_COUNT = 8
EIP7594_MAX_BLOBS_PER_BLOCK = 8
EIP7594_TARGET_BLOBS_PER_BLOCK = 4

@Gulrizwan23

This comment was marked as spam.

@tbenr
Copy link
Contributor

tbenr commented Oct 21, 2024

to be consistent with what we've done previously with MAX_REQUEST_BLOCKS and MAX_REQUEST_BLOCKS_DENEB I think we should keep existing names as is and add

BLOB_SIDECAR_SUBNET_COUNT_PECTRA: 8
# MAX_REQUEST_BLOCKS_DENEB * MAX_BLOBS_PER_BLOCK_PECTRA
MAX_REQUEST_BLOB_SIDECARS_PECTRA: 1024
MAX_BLOBS_PER_BLOCK_PECTRA: 8
TARGET_BLOBS_PER_BLOCK_PECTRA: 4

In theory, since there is no previous TARGET_BLOBS_PER_BLOCK, to do the exact same thing we did before we should add it without PECTRA but maybe in this case we could add it straight.

@rolfyone
Copy link
Contributor

BLOB_SIDECAR_SUBNET_COUNT_PECTRA: 8
# MAX_REQUEST_BLOCKS_DENEB * MAX_BLOBS_PER_BLOCK_PECTRA
MAX_REQUEST_BLOB_SIDECARS_PECTRA: 1024
MAX_BLOBS_PER_BLOCK_PECTRA: 8
TARGET_BLOBS_PER_BLOCK_PECTRA: 4

PECTRA would be ELECTRA here i assume...

@tbenr
Copy link
Contributor

tbenr commented Oct 22, 2024

PECTRA would be ELECTRA here i assume...

oh gosh 🤦 ... obviously...

BLOB_SIDECAR_SUBNET_COUNT_ELECTRA: 8
# MAX_REQUEST_BLOCKS_DENEB * MAX_BLOBS_PER_BLOCK_ELECTRA
MAX_REQUEST_BLOB_SIDECARS_ELECTRA: 1024
MAX_BLOBS_PER_BLOCK_ELECTRA: 8
TARGET_BLOBS_PER_BLOCK_ELECTRA: 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-7594 PeerDAS
Projects
None yet
Development

No branches or pull requests

5 participants