Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validators from persistent committees after exit #272

Closed
JustinDrake opened this issue Dec 10, 2018 · 2 comments
Closed

Remove validators from persistent committees after exit #272

JustinDrake opened this issue Dec 10, 2018 · 2 comments
Labels
general:bug Something isn't working

Comments

@JustinDrake
Copy link
Collaborator

At the moment exit_validator removes a validator from the persistent committees when updating the status ACTIVE_PENDING_EXIT. We should wait for an exit event (EXITED_WITHOUT_PENALTY or EXITED_WITH_PENALTY) to remove a validator from the persistent committees.

@JustinDrake JustinDrake added the general:bug Something isn't working label Dec 10, 2018
@djrtwo
Copy link
Contributor

djrtwo commented Dec 10, 2018

pulled this list from #253

  • Replace the code under # Exit validator with a call to exit_validator
  • Only remove validator from persistent committees and update validator_registry_delta_chain_tip if there's an actual exit event (i.e. EXITED_WITH_PENALTY or EXITED_WITHOUT_PENALTY).
  • Abstract away all the grunt work around status changes (e.g. regarding validator_registry_delta_chain_tip, status, latest_status_change_slot) into an update_validator_status function.

@djrtwo
Copy link
Contributor

djrtwo commented Dec 10, 2018

ah, closing in favor of #274

@djrtwo djrtwo closed this as completed Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants