-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardizing default p2p ports #2011
Comments
Somewhat related, eth2.0-metrics specifies a standard port: https://github.com/ethereum/eth2.0-metrics/blob/master/metrics.md#prometheus-metrics-collection
|
I figured it wasn't worth deciding on until #2008 is figured out. If we ultimately decide that agent-string should be kept, then this privacy concern is a non-issue. |
Also, sharing default ports has some emergent issues when people try to run multiple clients on same machine. Not really a huge issue on mainnet, but an annoyance @benjaminion mentioned picking the same port as lighthouse as a "poor decision"
|
The ship has sailed here, each client has its own default port |
RE: Validator privacy concerns mentioned in ethereum/eth2.0-pm#171
If client A and client B differ by their default ports, nodes on the network are easily sorted into client type based on port number alone.
Should the spec include a SHOULD default port for discv5 + libp2p?
The text was updated successfully, but these errors were encountered: