From 7589af8e8d394a45647d2f2a7f271271e39addd1 Mon Sep 17 00:00:00 2001 From: Danny Ryan Date: Wed, 4 Nov 2020 09:18:46 -0600 Subject: [PATCH] remove wip notice on phase 0 specs --- configs/minimal/phase0.yaml | 2 +- specs/phase0/beacon-chain.md | 6 +----- specs/phase0/deposit-contract.md | 2 -- specs/phase0/fork-choice.md | 2 -- specs/phase0/p2p-interface.md | 2 -- specs/phase0/validator.md | 2 +- specs/phase0/weak-subjectivity.md | 2 -- ssz/simple-serialize.md | 2 -- .../eth2spec/test/phase0/genesis/test_validity.py | 10 ---------- 9 files changed, 3 insertions(+), 27 deletions(-) diff --git a/configs/minimal/phase0.yaml b/configs/minimal/phase0.yaml index aa9f1b1264..93337adf82 100644 --- a/configs/minimal/phase0.yaml +++ b/configs/minimal/phase0.yaml @@ -54,7 +54,7 @@ SECONDS_PER_ETH1_BLOCK: 14 # Ethereum Goerli testnet DEPOSIT_CHAIN_ID: 5 DEPOSIT_NETWORK_ID: 5 -# **TBD** +# Configured on a per testnet basis DEPOSIT_CONTRACT_ADDRESS: 0x1234567890123456789012345678901234567890 diff --git a/specs/phase0/beacon-chain.md b/specs/phase0/beacon-chain.md index 5f80d01b27..fcd681115a 100644 --- a/specs/phase0/beacon-chain.md +++ b/specs/phase0/beacon-chain.md @@ -1,7 +1,5 @@ # Ethereum 2.0 Phase 0 -- The Beacon Chain -**Notice**: This document is a work-in-progress for researchers and implementers. - ## Table of contents @@ -177,7 +175,7 @@ The following values are (non-configurable) constants used throughout the specif ## Configuration -*Note*: The default mainnet configuration values are included here for spec-design purposes. The different configurations for mainnet, testnets, and YAML-based testing can be found in the [`configs/constant_presets`](../../configs) directory. These configurations are updated for releases and may be out of sync during `dev` changes. +*Note*: The default mainnet configuration values are included here for illustrative purposes. The different configurations for mainnet, testnets, and YAML-based testing can be found in the [`configs/constant_presets`](../../configs) directory. ### Misc @@ -1191,8 +1189,6 @@ def is_valid_genesis_state(state: BeaconState) -> bool: return True ``` -*Note*: The `is_valid_genesis_state` function (including `MIN_GENESIS_TIME` and `MIN_GENESIS_ACTIVE_VALIDATOR_COUNT`) is a placeholder for testing. It has yet to be finalized by the community, and can be updated as necessary. - ### Genesis block Let `genesis_block = BeaconBlock(state_root=hash_tree_root(genesis_state))`. diff --git a/specs/phase0/deposit-contract.md b/specs/phase0/deposit-contract.md index 6036da2d68..8b3035629f 100644 --- a/specs/phase0/deposit-contract.md +++ b/specs/phase0/deposit-contract.md @@ -1,7 +1,5 @@ # Ethereum 2.0 Phase 0 -- Deposit Contract -**Notice**: This document is a work-in-progress for researchers and implementers. - ## Table of contents diff --git a/specs/phase0/fork-choice.md b/specs/phase0/fork-choice.md index f0b25d95c0..8bc108caaa 100644 --- a/specs/phase0/fork-choice.md +++ b/specs/phase0/fork-choice.md @@ -1,7 +1,5 @@ # Ethereum 2.0 Phase 0 -- Beacon Chain Fork Choice -**Notice**: This document is a work-in-progress for researchers and implementers. - ## Table of contents diff --git a/specs/phase0/p2p-interface.md b/specs/phase0/p2p-interface.md index 0f1767710c..43a097f7e3 100644 --- a/specs/phase0/p2p-interface.md +++ b/specs/phase0/p2p-interface.md @@ -1219,8 +1219,6 @@ For minimum and maximum allowable slot broadcast times, Although messages can at times be eagerly gossiped to the network, the node's fork choice prevents integration of these messages into the actual consensus until the _actual local start_ of the designated slot. -The value of this constant is currently a placeholder and will be tuned based on data observed in testnets. - ### Why are there `ATTESTATION_SUBNET_COUNT` attestation subnets? Depending on the number of validators, it may be more efficient to group shard subnets and might provide better stability for the gossipsub channel. diff --git a/specs/phase0/validator.md b/specs/phase0/validator.md index 10cfc304a9..c6a91dcfcb 100644 --- a/specs/phase0/validator.md +++ b/specs/phase0/validator.md @@ -1,6 +1,6 @@ # Ethereum 2.0 Phase 0 -- Honest Validator -**Notice**: This document is a work-in-progress for researchers and implementers. This is an accompanying document to [Ethereum 2.0 Phase 0 -- The Beacon Chain](./beacon-chain.md), which describes the expected actions of a "validator" participating in the Ethereum 2.0 protocol. +This is an accompanying document to [Ethereum 2.0 Phase 0 -- The Beacon Chain](./beacon-chain.md), which describes the expected actions of a "validator" participating in the Ethereum 2.0 protocol. ## Table of contents diff --git a/specs/phase0/weak-subjectivity.md b/specs/phase0/weak-subjectivity.md index 7417053f5b..9d433de8ee 100644 --- a/specs/phase0/weak-subjectivity.md +++ b/specs/phase0/weak-subjectivity.md @@ -1,7 +1,5 @@ # Ethereum 2.0 Phase 0 -- Weak Subjectivity Guide -**Notice**: This document is a work-in-progress for researchers and implementers. - ## Table of contents diff --git a/ssz/simple-serialize.md b/ssz/simple-serialize.md index 4cc590ea26..b0e7ec1e09 100644 --- a/ssz/simple-serialize.md +++ b/ssz/simple-serialize.md @@ -1,7 +1,5 @@ # SimpleSerialize (SSZ) -**Notice**: This document is a work-in-progress describing typing, serialization, and Merkleization of Eth2 objects. - ## Table of contents diff --git a/tests/core/pyspec/eth2spec/test/phase0/genesis/test_validity.py b/tests/core/pyspec/eth2spec/test/phase0/genesis/test_validity.py index 7bdfe1a426..28cd3544bc 100644 --- a/tests/core/pyspec/eth2spec/test/phase0/genesis/test_validity.py +++ b/tests/core/pyspec/eth2spec/test/phase0/genesis/test_validity.py @@ -59,16 +59,6 @@ def test_is_valid_genesis_state_true_more_balance(spec): yield from run_is_valid_genesis_state(spec, state, valid=True) -# TODO: not part of the genesis function yet. Erroneously merged. -# @with_phases([PHASE0]) -# @spec_test -# def test_is_valid_genesis_state_false_not_enough_balance(spec): -# state = create_valid_beacon_state(spec) -# state.validators[0].effective_balance = spec.MAX_EFFECTIVE_BALANCE - 1 -# -# yield from run_is_valid_genesis_state(spec, state, valid=False) - - @with_phases([PHASE0]) @spec_test @single_phase