Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PendingBalanceDeposit to PendingDeposit #478

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Rename PendingBalanceDeposit to PendingDeposit #478

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64da35e
Rename to pending deposit
ensi321 Oct 9, 2024
6892e3a
Update properties to match CL spec
nflaig Oct 9, 2024
008747d
Update types/electra/deposit.yaml
nflaig Oct 9, 2024
d014bd9
Merge branch 'master' into alpha8
ralexstokes Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions types/electra/deposit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,22 @@ Electra:
$ref: "../primitive.yaml#/Uint64"
description: "The index of the deposit request."

PendingBalanceDeposit:
PendingDeposit:
type: object
description: "The [`PendingBalanceDeposit`](https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.5/specs/electra/beacon-chain.md#pendingbalancedeposit) object from the CL Electra spec."
required: [index, amount]
description: "The [`PendingDeposit`](https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.8/specs/electra/beacon-chain.md#pendingdeposit) object from the CL Electra spec."
required: [pubkey, withdrawal_credentials, amount, signature, slot]
properties:
nflaig marked this conversation as resolved.
Show resolved Hide resolved
index:
$ref: "../primitive.yaml#/Uint64"
description: "Index of validator in validator registry."
pubkey:
$ref: "../primitive.yaml#/Pubkey"
description: "BLS public key of validator."
withdrawal_credentials:
$ref: "../primitive.yaml#/Root"
description: "The withdrawal credentials."
amount:
$ref: "../primitive.yaml#/Gwei"
description: "The value to be deposited (gwei)."
signature:
$ref: "../primitive.yaml#/Signature"
slot:
$ref: "../primitive.yaml#/Uint64"
description: "The slot at which the deposit request was processed"
nflaig marked this conversation as resolved.
Show resolved Hide resolved
6 changes: 3 additions & 3 deletions types/electra/state.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Electra:
BeaconState:
type: object
description: "The [`BeaconState`](https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.5/specs/electra/beacon-chain.md#beaconstate) object from the CL Electra spec."
required: [genesis_time, genesis_validators_root, slot, fork, latest_block_header, block_roots, state_roots, historical_roots, eth1_data, eth1_data_votes, eth1_deposit_index, validators, balances, randao_mixes, slashings, previous_epoch_participation, current_epoch_participation, justification_bits, previous_justified_checkpoint, current_justified_checkpoint, finalized_checkpoint, inactivity_scores, current_sync_committee, next_sync_committee, latest_execution_payload_header, next_withdrawal_index, next_withdrawal_validator_index, historical_summaries, deposit_requests_start_index, deposit_balance_to_consume, exit_balance_to_consume, earliest_exit_epoch, consolidation_balance_to_consume, earliest_consolidation_epoch, pending_balance_deposits, pending_partial_withdrawals, pending_consolidations]
required: [genesis_time, genesis_validators_root, slot, fork, latest_block_header, block_roots, state_roots, historical_roots, eth1_data, eth1_data_votes, eth1_deposit_index, validators, balances, randao_mixes, slashings, previous_epoch_participation, current_epoch_participation, justification_bits, previous_justified_checkpoint, current_justified_checkpoint, finalized_checkpoint, inactivity_scores, current_sync_committee, next_sync_committee, latest_execution_payload_header, next_withdrawal_index, next_withdrawal_validator_index, historical_summaries, deposit_requests_start_index, deposit_balance_to_consume, exit_balance_to_consume, earliest_exit_epoch, consolidation_balance_to_consume, earliest_consolidation_epoch, pending_deposits, pending_partial_withdrawals, pending_consolidations]
properties:
genesis_time:
$ref: "../primitive.yaml#/Uint64"
Expand Down Expand Up @@ -104,10 +104,10 @@ Electra:
$ref: "../primitive.yaml#/Gwei"
earliest_consolidation_epoch:
$ref: "../primitive.yaml#/Uint64"
pending_balance_deposits:
pending_deposits:
type: array
items:
$ref: "./deposit.yaml#/Electra/PendingBalanceDeposit"
$ref: "./deposit.yaml#/Electra/PendingDeposit"
maxItems: 134217728
pending_partial_withdrawals:
type: array
Expand Down