Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update publishBlindedBlockV2 request schema for Deneb #321

Merged
merged 2 commits into from
May 29, 2023
Merged

Update publishBlindedBlockV2 request schema for Deneb #321

merged 2 commits into from
May 29, 2023

Conversation

jimmygchen
Copy link
Contributor

@jimmygchen jimmygchen commented May 29, 2023 •
edited
Loading

Updated the publishBlindedBlockV2 to use the Deneb.SignedBlindedBlockContents schema for Deneb.

I think the blob signing endpoints PR #302 was merged right after publishBlindedBlockV2 was added in #317, and the publishBlindedBlockV2 method was missing a schema change for Deneb.

@rkapka
Copy link
Collaborator

rkapka commented May 29, 2023

Thanks for this! Can you also fix publishBlockV2? It uses Deneb.SignedBeaconBlock instead of Deneb.SignedBlockContents.

@jimmygchen
Copy link
Contributor Author

Thanks for this! Can you also fix publishBlockV2? It uses Deneb.SignedBeaconBlock instead of Deneb.SignedBlockContents.

Good catch, I've updated publishBlockV2. Thanks!

rolfyone
rolfyone approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - LGTM.

@rolfyone rolfyone merged commit 2a15cc7 into ethereum:master May 29, 2023
@jimmygchen jimmygchen deleted the update-publishBlindedBlockV2-deneb branch May 30, 2023 22:33
@tersec tersec mentioned this pull request Jun 8, 2023
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmygchen @rkapka @rolfyone