Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getBlobSidecars is missing metadata fields in response #439

Closed
nflaig opened this issue Apr 5, 2024 · 0 comments · Fixed by #441
Closed

getBlobSidecars is missing metadata fields in response #439

nflaig opened this issue Apr 5, 2024 · 0 comments · Fixed by #441

Comments

@nflaig
Copy link
Collaborator

nflaig commented Apr 5, 2024

It looks like getBlobSidecars API does not include execution_optimistic and finalized fields

beacon-APIs/apis/beacon/blob_sidecars/blob_sidecars.yaml

Lines 34 to 37 in fc89ec5

required: [data]
properties:
data:
$ref: "../../../beacon-node-oapi.yaml#/components/schemas/Deneb.BlobSidecars"

Whereas the getBlockV2 does and even includes version which we might wanna add for blobs as well

beacon-APIs/apis/beacon/blocks/block.v2.yaml

Line 25 in fc89ec5

required: [version, execution_optimistic, finalized, data]

I don't see any discussion on this in #286, so I guess it was just missed?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add metadata fields to getBlobSidecars response nflaig/beacon-APIs
1 participant
@nflaig