Add ERC: Named NFT #320
Add ERC: Named NFT #320
Conversation
Co-authored-by: Andrew B Coathup <[email protected]>
| --- | ||
| eip: 7653 | ||
| title: Named NFT | ||
| description: An extension to ERC-721 based on ERC-7632. |
There was a problem hiding this comment.
Your description doesn't really say anything about what's in this proposal. It only says where to look for more information.
It'd be nice to see at a glance what's actually in this document.
|
|
||
| ## Abstract | ||
|
|
||
| An extension to `ERC-721` based on `ERC-7632` to enable named `ERC-721` |
There was a problem hiding this comment.
| An extension to `ERC-721` based on `ERC-7632` to enable named `ERC-721` | |
| An extension to [ERC-721](./eip-721.md) based on [ERC-7632](./eip-7632.md) to enable named ERC-721. |
Don't use backticks to bypass the linter.
|
|
||
| ## Abstract | ||
|
|
||
| An extension to `ERC-721` based on `ERC-7632` to enable named `ERC-721` |
There was a problem hiding this comment.
Your abstract is certainly terse, but it doesn't contain enough information about what the proposal actually does. What is a named NFT? How do the names work?
|
|
||
| The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119 and RFC 8174. | ||
|
|
||
| 1. A compliant contract MUST implement `ERC-721` and following interface |
There was a problem hiding this comment.
| 1. A compliant contract MUST implement `ERC-721` and following interface | |
| 1. A compliant contract MUST implement `ERC721` and following interface |
| } | ||
| ``` | ||
|
|
||
| 2. A compliant contract MUST implement the `ERC-165` |
There was a problem hiding this comment.
| 2. A compliant contract MUST implement the `ERC-165` | |
| 2. A compliant contract MUST implement the `ERC165` interface |
|
|
||
| ## Rationale | ||
|
|
||
| Needs discussion |
There was a problem hiding this comment.
| Needs discussion | |
| Needs discussion <!-- TODO --> |
|
|
||
| ## Backwards Compatibility | ||
|
|
||
| This ERC is designed to be backward compatible with `ERC-721` |
There was a problem hiding this comment.
| This ERC is designed to be backward compatible with `ERC-721` | |
| This ERC is designed to be backward compatible with ERC-721. |
|
|
||
| ## Security Considerations | ||
|
|
||
| Needs discussion. |
There was a problem hiding this comment.
| Needs discussion. | |
| Needs discussion. <!-- TODO --> |
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: