Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC-6672: Update erc-6672.md #285

Merged
merged 1 commit into from
May 22, 2024
Merged

Update ERC-6672: Update erc-6672.md #285

merged 1 commit into from
May 22, 2024

Conversation

ArchieR7
Copy link
Contributor

Fix the handle of co-author.

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@ArchieR7
Update erc-6672.md
65b13fd 
Fix the handle of co-author.
@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Feb 29, 2024 •
edited
Loading

File ERCS/erc-6672.md

Requires 1 more reviewers from @axic, @gcolvin, @lightclient

@eip-review-bot eip-review-bot changed the title Update erc-6672.md Update ERC-6672: Update erc-6672.md Feb 29, 2024
@poojaranjan poojaranjan mentioned this pull request Mar 5, 2024
Closed
10 tasks
SamWilsn
SamWilsn approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified Jason's new username (via email.)

@poojaranjan poojaranjan mentioned this pull request Mar 27, 2024
Closed
16 tasks
xinbenlv
xinbenlv approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, per @SamWilsn verified

SamWilsn
SamWilsn requested changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel comfortable overriding the bot without going through the process:

ethcatherders/EIPIP#331

@SamWilsn SamWilsn merged commit c1ea0d6 into ethereum:master May 22, 2024
17 of 18 checks passed
@SamWilsn SamWilsn mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn requested changes

@xinbenlv xinbenlv xinbenlv approved these changes

@eip-review-bot eip-review-bot Awaiting requested review from eip-review-bot eip-review-bot is a code owner

Assignees
No one assigned
Labels
c-update e-consensus s-final t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArchieR7 @eip-review-bot @xinbenlv @SamWilsn