Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-7425: Add missing info #238

Merged
merged 9 commits into from
Feb 20, 2024
Merged

Conversation

jimstir
Copy link
Contributor

@jimstir jimstir commented Feb 6, 2024

Add a security consideration and improve specification language for clarity.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Feb 6, 2024

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Update ERC-7425 Update ERC-7425: Update ERC-7425 Feb 6, 2024
@eip-review-bot eip-review-bot enabled auto-merge (squash) February 6, 2024 07:31
eip-review-bot
eip-review-bot previously approved these changes Feb 6, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@jimstir jimstir marked this pull request as draft February 6, 2024 07:33
auto-merge was automatically disabled February 6, 2024 07:33

Pull request was converted to draft

@github-actions github-actions bot added the w-ci label Feb 6, 2024
@jimstir jimstir changed the title Update ERC-7425: Update ERC-7425 Update ERC-7425: Add missing info Feb 6, 2024
@jimstir jimstir marked this pull request as ready for review February 6, 2024 11:58
@eip-review-bot eip-review-bot enabled auto-merge (squash) February 6, 2024 11:59
eip-review-bot
eip-review-bot previously approved these changes Feb 6, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled February 6, 2024 12:05

Head branch was pushed to by a user without write access

@eip-review-bot eip-review-bot enabled auto-merge (squash) February 6, 2024 12:06
eip-review-bot
eip-review-bot previously approved these changes Feb 6, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled February 7, 2024 04:00

Head branch was pushed to by a user without write access

@eip-review-bot eip-review-bot enabled auto-merge (squash) February 7, 2024 04:01
eip-review-bot
eip-review-bot previously approved these changes Feb 7, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled February 14, 2024 16:47

Head branch was pushed to by a user without write access

@eip-review-bot eip-review-bot enabled auto-merge (squash) February 14, 2024 16:48
eip-review-bot
eip-review-bot previously approved these changes Feb 14, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled February 20, 2024 06:02

Head branch was pushed to by a user without write access

@eip-review-bot eip-review-bot enabled auto-merge (squash) February 20, 2024 06:03
eip-review-bot
eip-review-bot previously approved these changes Feb 20, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled February 20, 2024 06:04

Head branch was pushed to by a user without write access

@github-actions github-actions bot removed the w-ci label Feb 20, 2024
@eip-review-bot eip-review-bot enabled auto-merge (squash) February 20, 2024 06:05
eip-review-bot
eip-review-bot previously approved these changes Feb 20, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled February 20, 2024 06:06

Head branch was pushed to by a user without write access

@eip-review-bot eip-review-bot enabled auto-merge (squash) February 20, 2024 06:06
eip-review-bot
eip-review-bot previously approved these changes Feb 20, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link

The commit 6dc54cf (as a parent of 4d011f0) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Feb 20, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit fa962f5 into ethereum:master Feb 20, 2024
9 of 11 checks passed
@github-actions github-actions bot removed the w-ci label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants