Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1: add external links for post-quantum algorithm implementations #8245

Closed

Conversation

eum602
Copy link

@eum602 eum602 commented Feb 19, 2024

Hello, this PR proposes to add new PQClean implementations. The intention of this PR is to allow such references in new EIP proposals such as Precompile Falcon512 generic verifier

@eum602 eum602 requested a review from eth-bot as a code owner February 19, 2024 20:11
@github-actions github-actions bot added c-update Modifies an existing proposal t-process labels Feb 19, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 19, 2024

File EIPS/eip-1.md

Requires 3 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

@SamWilsn
Copy link
Contributor

I've created a "Call for Input" to collect input from EIP Editors: ethcatherders/EIPIP#318

@SamWilsn
Copy link
Contributor

It might be easier if you can provide a source with a DOI number (eg. 10.1007/3-540-48071-4_1). We allow any links that have DOIs without any special exceptions.

@eum602
Copy link
Author

eum602 commented Feb 20, 2024

It might be easier if you can provide a source with a DOI number (eg. 10.1007/3-540-48071-4_1). We allow any links that have DOIs without any special exceptions.

Thanks for pointing it out @SamWilsn . I couldn't find a DOI for Falcon; since all information was originally published in the author's page (https://falcon-sign.info/) which is the main page that implementers refer to. There the key differentiator is the specification version (20211101) . For example that number is used in the OpenQuantumSafe project to point the specification version they use. Just leaving this information to hopefully find a way to address the observation.

@SamWilsn
Copy link
Contributor

Sorry for the runaround on this @eum602; thanks a ton for putting up with us!

You mentioned that you're going to copy the implementation into your assets directory instead, so I'm going to close this PR.

@SamWilsn SamWilsn closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus t-process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants