-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Hardfork Meta - Pectra #8121
Conversation
Signed-off-by: Tim Beiko <[email protected]>
✅ All reviewers have approved. |
Signed-off-by: Tim Beiko <[email protected]>
Signed-off-by: Tim Beiko <[email protected]>
EIPS/eip-praguemeta.md
Outdated
@@ -0,0 +1,58 @@ | |||
--- | |||
eip: XXXX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eip: XXXX | |
eip: 7600 |
Assigning next sequential EIP/ERC/RIP number.
Numbering changed to sequential from 7500 and is no longer the PR number.
Please also update the filename.
EIPS/eip-praguemeta.md
Outdated
@@ -0,0 +1,58 @@ | |||
--- | |||
eip: XXXX | |||
title: Hardfork Meta - Prague/Electra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Hardfork Meta - Prague/Electra | |
title: Hardfork Meta - Pectra |
@lightclient named Prague + Electra upgrade as Pectra on all core devs - execution 178
https://www.youtube.com/watch?v=6xgxmKfVjtA&t=1890s
Signed-off-by: Tim Beiko <[email protected]>
Signed-off-by: Tim Beiko <[email protected]>
Co-authored-by: Ryan Schneider <[email protected]>
Co-authored-by: Andrew B Coathup <[email protected]>
|
||
## Rationale | ||
|
||
This Meta EIP provides a global view of all changes included in the Prague/Electra network upgrade, as well as links to full specification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rationale section should justify decisions made within the EIP, not the EIP as a whole. Unless you actually want to explain why these particular EIPs are being included, I think you should just omit this section as it doesn't really make sense. Would require an override on the bots though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My last two Meta EIPs had such rationales, but I'm happy with whatever. Feels simpler to not have to override the bot all the time, but also OK to delete this.
For reference:
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
The commit 6085cf3 (as a parent of 3a4b287) contains errors. |
We agreed to name this fork Pectra on ACDC#127 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
ready to merge 😄