-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-4844: clarify to must be non-nil #7100
Conversation
nice number |
✅ All reviewers have approved. |
d6f9226
to
ca3b4f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Pull request was converted to draft
Co-authored-by: Ansgar Dietrichs <[email protected]>
5cb1a10
to
1fb71fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
@karalabe raised a concern that the current transaction type spec in 4844 is not clear on whether a
nil
to
field is allowed. This PR aims at clarifying any confusion around the correct representation of blob txs.