Update EIP-1185: Move to Review #6970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-status
|
✅ All reviewers have approved. |
eth-bot
changed the title
20 tasks
19 tasks
SamWilsn
reviewed
May 30, 2023
There was a problem hiding this comment.
Some changes I can't comment directly on:
- Lines 26-28 (from "Traditionally, DNS is a zone-based system..." to "... considered further for this EIP") belong in the Rationale section since they explain choices made within the proposal.
- Please surround code snippets in headings with backticks (`).
- You can (and should) add links to relevant RFCs using their DOIs (like 10.17487/RFC1034). You can see an example here.
- The current content of the rationale section justifies the EIP as a whole, so it should be moved to the motivation section.
|
Nothing block advancing to review, hence the approval. |
xinbenlv
approved these changes
Jun 1, 2023
eth-bot
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.