Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-6357: Move to Review #6592

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Update EIP-6357: Move to Review #6592

merged 1 commit into from
Apr 4, 2023

Conversation

Pandapip1
Copy link
Member

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Feb 28, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 28, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added the e-review Waiting on editor to review label Feb 28, 2023
@poojaranjan poojaranjan mentioned this pull request Mar 7, 2023
Closed
25 tasks
SamWilsn
SamWilsn reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the rationale be fleshed out?

@Pandapip1
Copy link
Member Author

Fixed. #6655

@Pandapip1 Pandapip1 requested a review from SamWilsn March 8, 2023 22:21
@SamWilsn
Copy link
Contributor

The security considerations section is still "Needs discussion."

@Pandapip1
Copy link
Member Author

Pandapip1 commented Mar 21, 2023 •
edited
Loading

The security considerations section is still "Needs discussion."

No it isn't. The branch isn't up-to-date. Sorry, yes, the security considerations are still incomplete. I'll fix that.

@Pandapip1
Copy link
Member Author

Fixed with #6738

@poojaranjan poojaranjan mentioned this pull request Apr 4, 2023
Closed
16 tasks
@eth-bot eth-bot changed the title Update ERC-6357: Move to Review Update EIP-6357: Move to Review Apr 4, 2023
@eth-bot eth-bot enabled auto-merge (squash) April 4, 2023 15:39
eth-bot
eth-bot approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit da04195 into master Apr 4, 2023
@eth-bot eth-bot deleted the Pandapip1-patch-6 branch April 4, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

Assignees
No one assigned
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-review This EIP is in Review t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pandapip1 @eth-bot @SamWilsn