Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC3986(URI) to assets/RFCs #5296

Closed
wants to merge 4 commits into from
Closed

Conversation

xinbenlv
Copy link
Contributor

@xinbenlv xinbenlv commented Jul 19, 2022

License: Distribution of this memo is unlimited.
This is a follow up of @Pandapip1 's proposal #5272

Temporarily checking in the text version. Will update if the decision to include html as required format is made

License: `Distribution of this memo is unlimited.`
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 19, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) assets/RFCs/rfc3986.html

classification
ambiguous
  • 'assets/RFCs/rfc3986.html' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

@xinbenlv
Copy link
Contributor Author

Bot assessment was not relevant. It seems only supporting EIP updates.

@MicahZoltu
Copy link
Contributor

There was a desire to include the HTML version, rather than the TXT version I believe.

@xinbenlv
Copy link
Contributor Author

There was a desire to include the HTML version, rather than the TXT version I believe.

@MicahZoltu yes, acknowledged. I mention this in the body of PR per

Temporarily checking in the text version. Will update if the decision to include html as required format is made

@Pandapip1
Copy link
Member

The decision to use unmodified HTML was made.

@xinbenlv
Copy link
Contributor Author

Done

@github-actions
Copy link

The commit 7231d86 (as a parent of 213ef96) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

The commit b9559f4 (as a parent of 213ef96) contains errors. Please inspect the Run Summary for details.

@xinbenlv
Copy link
Contributor Author

EIPW complains

- 'assets/RFCs/rfc3986.html' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

Could one of the Editors give an overriding approval?

@Pandapip1
Copy link
Member

No, not yet. The PR making the relevant change has not yet been merged.

@eth-bot eth-bot dismissed a stale review via b9559f4 August 10, 2022 17:12
@xinbenlv xinbenlv requested a review from eth-bot as a code owner August 14, 2022 03:08
@xinbenlv
Copy link
Contributor Author

The depending #5272 is now merged.
Please consider merging this PR

@xinbenlv
Copy link
Contributor Author

Actually, this is no-longer needed.

@xinbenlv xinbenlv closed this Aug 14, 2022
@github-actions
Copy link

The commit 961014c (as a parent of dca267c) contains errors. Please inspect the Run Summary for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants