Modify eip-2930 gas accounting #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): |
|
@MicahZoltu just out of curiosity (I intend on addressing it regardless) would the previous bot have merged this provided that @lightclient is one of the people that would approve. |
|
@alita-moore I think new EIPs shouldn't be auto merged |
|
No, it shouldn't auto-merge. Ideally editors who author EIPs will get a review from another editor, or at least give an opportunity for other editors to review. |
MicahZoltu
approved these changes
Apr 22, 2021
EIPS/eip-3521.md
Outdated
| type: Standards Track | ||
| category: Core | ||
| created: 2021-04-15 | ||
| requires: 2028, 2718, 2929, 2930 |
There was a problem hiding this comment.
I think we can rely on 2718 and 2929 being transitively included via 2930 so we could narrow this to only 2028, 2930 I think.
Co-authored-by: Micah Zoltu <[email protected]>
lightclient
commented
Apr 22, 2021
lightclient
commented
Apr 22, 2021
lightclient
commented
Apr 22, 2021
phi-line
pushed a commit
to phi-line/EIPs
that referenced
this pull request
Apr 29, 2021
* modify eip-2930 gas accounting * add title * add eip number and discussion link * typo * Update EIPS/eip-3521.md Co-authored-by: Micah Zoltu <[email protected]> * Update EIPS/eip-3521.md * Update EIPS/eip-3521.md * Update EIPS/eip-3521.md Co-authored-by: Micah Zoltu <[email protected]>
PhABC
pushed a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
* modify eip-2930 gas accounting * add title * add eip number and discussion link * typo * Update EIPS/eip-3521.md Co-authored-by: Micah Zoltu <[email protected]> * Update EIPS/eip-3521.md * Update EIPS/eip-3521.md * Update EIPS/eip-3521.md Co-authored-by: Micah Zoltu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^