-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch validator to eipv #2860
Switch validator to eipv #2860
Changes from all commits
bff86e3
533bb1a
0cbcc94
f6aeded
e25dd51
838d6a7
531fc72
a04f6ae
315ae8a
e716f61
208dd1a
4ee9314
f4219d8
32ffc82
6643038
322db84
29ad8dc
f7f4ff5
c801d96
ecc7481
cfc26d6
a853f50
62b4896
b88899c
f066a78
a41e4ae
db83eec
57c9e28
c3da24f
64bc976
d038a25
75986bd
39d6036
4c7851a
0fa9d62
3d2a8ac
f48a465
81e7d61
7a25c9b
128404e
d274a9f
2da2916
87f75fc
89af85b
35da03e
bb0d5b5
45c06d4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,6 @@ title: EIP Purpose and Guidelines | |
status: Active | ||
type: Meta | ||
author: Martin Becze <[email protected]>, Hudson Jameson <[email protected]>, and others | ||
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1.md | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not clear what purpose this URL served here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have changed this file locally just never submitted a PR. My understanding it tries to signal "look at the history". What I opted for was "Martin ..., Hudson ..., et al." There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh I see, it was supposed to be a part of the authors field. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we change the authors for EIP-1 to just "Contributors Like You". 🚎 /not-🚎 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't have a strong feeling towards this, but IMO it's outside the scope of this PR. |
||
created: 2015-10-27 | ||
updated: 2015-12-07, 2016-02-01, 2018-03-21, 2018-05-29, 2018-10-17, 2019-05-19, 2019-12-04, 2020-06-17 | ||
--- | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
eip: 1057 | ||
title: ProgPoW, a Programmatic Proof-of-Work | ||
author: Greg Colvin <[email protected]>, Andrea Lanfranchi (@AndreaLanfranchi), Michael Carter (@bitsbetrippin), IfDefElse <[email protected]> | ||
author: Greg Colvin <[email protected]>, Andrea Lanfranchi (@AndreaLanfranchi), Michael Carter (@bitsbetrippin), IfDefElse <[email protected]> | ||
discussions-to: https://ethereum-magicians.org/t/eip-progpow-a-programmatic-proof-of-work/272 | ||
status: Accepted | ||
type: Standards Track | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
--- | ||
eip: 1186 | ||
title: RPC-Method to get Merkle Proofs - eth_getProof | ||
title: RPC-Method to get Merkle Proofs - eth_getProof | ||
author: Simon Jentzsch <[email protected]>, Christoph Jentzsch <[email protected]> | ||
discussions-to: https://github.com/ethereum/EIPs/issues/1186 | ||
status: Draft | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
eip: 1337 | ||
title: Subscriptions on the blockchain | ||
author: Kevin Owocki <[email protected]> , Andrew Redden <[email protected]>, Scott Burke <[email protected]> , Kevin Seagraves <[email protected]> , Luka Kacil <[email protected]>, Štefan Šimec <[email protected]>, Piotr Kosiński (@kosecki123), ankit raj <[email protected]>, John Griffin <[email protected]> , Nathan Creswell <[email protected]> | ||
author: Kevin Owocki <[email protected]>, Andrew Redden <[email protected]>, Scott Burke <[email protected]>, Kevin Seagraves <[email protected]>, Luka Kacil <[email protected]>, Štefan Šimec <[email protected]>, Piotr Kosiński (@kosecki123), ankit raj <[email protected]>, John Griffin <[email protected]>, Nathan Creswell <[email protected]> | ||
discussions-to: https://ethereum-magicians.org/t/eip-1337-subscriptions-on-the-blockchain/4422 | ||
type: Standards Track | ||
status: Draft | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
eip: 1355 | ||
title: Ethash 1a | ||
author: Paweł Bylica (@chfast) <[email protected]>, Jean M. Cyr (@jean-m-cyr) | ||
author: Paweł Bylica (@chfast), Jean M. Cyr (@jean-m-cyr) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if we should include the person twice in this case, so that they are a valid author both by email and by GitHub handle? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (same comment elsewhere where this change was made) |
||
discussions-to: https://ethereum-magicians.org/t/eip-1355-ethash-1a/1167 | ||
status: Abandoned | ||
type: Standards Track | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
eip: 1485 | ||
title: TEthashV1 | ||
author: trustfarm (KT Ahn - 안씨아저씨) <[email protected]>, trustfarm <[email protected]> | ||
author: trustfarm <[email protected]>, trustfarm <[email protected]> | ||
discussions-to: https://ethereum-magicians.org/t/anti-eth-asic-mining-eip-1488-pr/1807 | ||
status: Draft | ||
type: Standards Track | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
eip: 1571 | ||
title: EthereumStratum/2.0.0 | ||
author: Andrea Lanfranchi (@AndreaLanfranchi) <[email protected]>, Pawel Bylica (@chfast) <[email protected]>, Marius Van Der Wijden (@MariusVanDerWijden) | ||
author: Andrea Lanfranchi (@AndreaLanfranchi), Pawel Bylica (@chfast), Marius Van Der Wijden (@MariusVanDerWijden) | ||
discussions-to: https://github.com/AndreaLanfranchi/EthereumStratum-2.0.0/issues | ||
status: Draft | ||
type: Standards Track | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
--- | ||
eip: 1613 | ||
eip: 1613 | ||
title: Gas stations network | ||
author: Yoav Weiss <[email protected]>, Dror Tirosh <[email protected]>, Alex Forshtat <[email protected]> | ||
discussions-to: https://github.com/yoav-tabookey/EIPs/issues/1 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
eip: 1620 | ||
title: ERC-1620 Money Streaming | ||
author: Paul Berg (@PaulRBerg) <[email protected]> | ||
author: Paul Berg (@PaulRBerg) | ||
discussions-to: https://github.com/ethereum/EIPs/issues/1620 | ||
status: Draft | ||
type: Standards Track | ||
|
@@ -302,4 +302,4 @@ There could be a way to avoid running two different streams in parallel. That is | |
Many thanks to @mmilton41 for countless brainstorming sessions. We have been doing research on the topic of money streaming for quite a while within the context of @ChronosProtocol. In August this year, we published the first version of our white paper describing a Plasma approach. However, in the meantime, we realised that it would be much more [fun](https://twitter.com/PaulRBerg/status/1056595919116910592) and easier to start small on Ethereum itself and sidechains like [xDai](https://blockscout.com/poa/dai). | ||
|
||
## Copyright | ||
Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/). | ||
Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/). |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
--- | ||
eip: 196 | ||
title: Precompiled contracts for addition and scalar multiplication | ||
on the elliptic curve alt_bn128 | ||
title: Precompiled contracts for addition and scalar multiplication on the elliptic curve alt_bn128 | ||
author: Christian Reitwiessner<[email protected]> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ^^ |
||
type: Standards Track | ||
category: Core | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
--- | ||
eip: 197 | ||
title: Precompiled contracts for optimal ate pairing check | ||
on the elliptic curve alt_bn128 | ||
title: Precompiled contracts for optimal ate pairing check on the elliptic curve alt_bn128 | ||
author: Vitalik Buterin <[email protected]>, Christian Reitwiessner <[email protected]> | ||
type: Standards Track | ||
category: Core | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
--- | ||
eip: 2009 | ||
title: Compliance Service | ||
title: Compliance Service | ||
author: Daniel Lehrner <[email protected]> | ||
discussions-to: https://github.com/ethereum/EIPs/issues/2022 | ||
status: Draft | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
eip: 214 | ||
title: New opcode STATICCALL | ||
author: Vitalik Buterin <[email protected]>, Christian Reitwiessner <[email protected]>; | ||
author: Vitalik Buterin <[email protected]>, Christian Reitwiessner <[email protected]> | ||
type: Standards Track | ||
category: Core | ||
status: Final | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ title: Subroutines and Static Jumps for the EVM | |
status: Draft | ||
type: Standards Track | ||
category: Core | ||
author: Greg Colvin <[email protected]>, Brooklyn Zelenka (@expede) , Paweł Bylica (@chfast), Christian Reitwiessner(@chriseth) | ||
author: Greg Colvin <[email protected]>, Brooklyn Zelenka (@expede), Paweł Bylica (@chfast), Christian Reitwiessner(@chriseth) | ||
discussions-to: https://ethereum-magicians.org/t/eip-615-subroutines-and-static-jumps-for-the-evm-last-call/3472 | ||
created: 2016-12-10 | ||
--- | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,7 @@ | ||
--- | ||
eip: 712 | ||
title: Ethereum typed structured data hashing and signing | ||
author: Remco Bloemen <[email protected]>, | ||
Leonid Logvinov <[email protected]>, | ||
Jacob Evans <[email protected]> | ||
author: Remco Bloemen <[email protected]>, Leonid Logvinov <[email protected]>, Jacob Evans <[email protected]> | ||
discussions-to: https://ethereum-magicians.org/t/eip-712-eth-signtypeddata-as-a-standard-for-machine-verifiable-and-human-readable-typed-data-signing/397 | ||
status: Draft | ||
type: Standards Track | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
eip: 884 | ||
title: 'DGCL Token' | ||
author: 'Dave Sag <[email protected]>' | ||
title: DGCL Token | ||
author: Dave Sag <[email protected]> | ||
type: Standards Track | ||
category: ERC | ||
status: Draft | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that the validator is currently not ensuring that titles are less than the max specified length and that each EIP has a
discussions-to
field. This is due to the number of non-conforming EIPs. I think formally increasing the max title length to support all current EIPs and then turning on the check is acceptable. With regards to thediscussions-to
field, there are some options:discussions-to
and only check new onesI prefer
1
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer 1 or 2. Anything that gets the system into a more standardized state so we can reliably use the bot going forward and don't need to maintain code to support malformed ancient EIPs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, prefer 1 or 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll follow the
1
path.