Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-4844: Explicit Clarification on Block Validity with Blob Transactions using an Invalid Versioned Hash #7009

Closed
marioevz opened this issue May 10, 2023 · 2 comments
Labels
bug If this is a PR, this PR fixes a bug. If this is an issue, this issue reports a bug.

Comments

@marioevz
Copy link
Member

Pull Request

No response

What happened?

Currently in the definition of the new transaction type of 4844, there is a paragraph that defines the execution invalidity properties of a block that includes this new transaction type.

The sole invalidity property for a block is currently that it cannot contain transactions of this new type that contain zero blobs.

Some client implementations have also included the check All hashes in blob_versioned_hashes must start with the byte BLOB_COMMITMENT_VERSION_KZG as part of execution block verification.

The paragraph describing the execution block verification should explicitly state whether or not the commitment version byte is a reason to invalidate a block.

If it should be a reason to invalidate:

Blob transactions with empty blob_versioned_hashes, or blob_versioned_hashes that don't start with the byte BLOB_COMMITMENT_VERSION_KZG, are also considered invalid during execution block verification, and must not be included in a valid block.

If it's not:

Blob transactions with empty blob_versioned_hashes are also considered invalid during execution block verification, and must not be included in a valid block.
Blob transactions with a value different than BLOB_COMMITMENT_VERSION_KZG as starting byte are not considered invalid during execution block verification.

Relevant log output

No response

@marioevz marioevz added the bug If this is a PR, this PR fixes a bug. If this is an issue, this issue reports a bug. label May 10, 2023
@g11tech
Copy link
Contributor

g11tech commented May 11, 2023

I think its better to always include the version as it would keep things straightforward and clean, especially when something goes wrong (and cost is hardly 1 byte per blob)

@Pandapip1
Copy link
Member

This is the wrong place to discuss changes to EIPs. Please open a PR making the relevant changes and share it to the discussions-to thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug If this is a PR, this PR fixes a bug. If this is an issue, this issue reports a bug.
Projects
None yet
Development

No branches or pull requests

3 participants